From dcb23f8b4b889061e96d43949d570581469cab84 Mon Sep 17 00:00:00 2001 From: hachem Date: Fri, 4 Sep 2026 07:04:49 +0200 Subject: refactor: slight cleanup --- src/core/window.cpp | 4 ++-- src/core/window.h | 2 +- src/core/window_manager.cpp | 2 +- src/core/window_manager.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/core') diff --git a/src/core/window.cpp b/src/core/window.cpp index 66500db..a87798a 100644 --- a/src/core/window.cpp +++ b/src/core/window.cpp @@ -106,9 +106,9 @@ namespace Hsdbg m_vsync = enabled; } - auto Window::set_title(std::string_view title) -> void + auto Window::set_title(std::string_view window_title) -> void { - m_title = title; + m_title = window_title; glfwSetWindowTitle(m_handle, m_title.c_str()); } diff --git a/src/core/window.h b/src/core/window.h index 6a4f747..d5cdaaf 100644 --- a/src/core/window.h +++ b/src/core/window.h @@ -34,7 +34,7 @@ namespace Hsdbg auto swap_buffers() -> void; auto set_vsync(bool enabled) -> void; - auto set_title(std::string_view title) -> void; + auto set_title(std::string_view window_title) -> void; auto handle() const -> GLFWwindow* { return m_handle; } auto title() const -> const std::string& { return m_title; } diff --git a/src/core/window_manager.cpp b/src/core/window_manager.cpp index f2e4af3..2b131d1 100644 --- a/src/core/window_manager.cpp +++ b/src/core/window_manager.cpp @@ -18,7 +18,7 @@ namespace Hsdbg glfwSetErrorCallback(on_error); - const bool initialized = glfwInit() == GLFW_TRUE; + [[maybe_unused]] const bool initialized = glfwInit() == GLFW_TRUE; HSDBG_ASSERT(initialized, "failed to initialize glfw"); Log::info("glfw {}", glfwGetVersionString()); diff --git a/src/core/window_manager.h b/src/core/window_manager.h index d3a915c..1101db9 100644 --- a/src/core/window_manager.h +++ b/src/core/window_manager.h @@ -23,8 +23,8 @@ namespace Hsdbg auto create_window(const WindowSpec& spec) -> Window&; auto destroy_window(const Window& window) -> void; - auto poll_events() -> void; - auto wait_events(double timeout_seconds) -> void; + static auto poll_events() -> void; + static auto wait_events(double timeout_seconds) -> void; auto window_count() const -> size_t { return m_windows.size(); } -- cgit v1.3